DataViews: Performance: check isEligible on dropdown open#63176
Open
DataViews: Performance: check isEligible on dropdown open#63176
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
gutenbergplugin
requested review from
gigitux,
ntsekouras and
oandregal
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Currently we check
isEligiblefor the trash, restore, and rename actions, even though these are not even rendered on load (the action buttons appear in a dropdown). This PR moves the checks to the place where the buttons are rendered.One catch is that we cannot disable the button when no actions are available. Instead, I added a message in the dropdown that no actions are available. I believe that's ok, and it should be rarer anyway?
Why?
It initiates an OPTION request for EACH item on load.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast