ComboboxControl component: Account for the value when displaying the available options#66634
Open
imrraaj wants to merge 1 commit intoWordPress:trunkfrom
Open
ComboboxControl component: Account for the value when displaying the available options#66634imrraaj wants to merge 1 commit intoWordPress:trunkfrom
imrraaj wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @leogermani. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
When using the ComboboxControl component, the available options are filtered by what's in the label of each option, but the value is discarded. This produces some unexpected behaviors where options that should be visible disappear.
If the slug does not match the name, and you search by that slug, the option will be hidden.
Why?
Fixes #64056
How?
This PR adds the option value and the label in the search criteria. So whenever uses tries to search using any of those values it will work fine.
Testing Instructions
Example: