Fix the search button overflow in the search block#66908
Fix the search button overflow in the search block#66908sarthaknagoshe2002 wants to merge 3 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @sarthaknagoshe2002! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
These issues are tricky because the resulting width is much wider than before, it is no longer going to be "25%" and the width option is no longer going to be respected, or am I wrong? |
|
Aside, but I think it might look better if the placeholder text was truncated with an ellipsis rather than cut off. |
|
@carolinan I have basically tried to match the UI on the frontend with the editor to serve 2 issues,
Also the overall size of the |
|
I have tested this again and the added padding breaks the button styling. |
|
@carolinan any other approach that you would like to suggest?? |
|
@carolinan I have updated the styling as per your suggestion to prevent the breaking of padding across different themes, please have a look. |
What?
This PR addresses the issue of the search button overflow when using
button insideatwidth=25%.Closes: #66906
Why?
This PR is necessary to ensure the UI doesn't break when selecting different editor options.
How?
This PR resolves the issue by matching the appearance of the block on frontend with that of the appearance in the editor
Testing Instructions
Testing Instructions for Keyboard
Verify button appearance: Use Tab and Shift confirming that the search button looks consistent and is contained within the search box in both the editor and on the frontend.
Screenshots or screencast