fix: ensure base_convert() is type int before division#68389
Open
justlevine wants to merge 1 commit intoWordPress:trunkfrom
Open
fix: ensure base_convert() is type int before division#68389justlevine wants to merge 1 commit intoWordPress:trunkfrom
base_convert() is type int before division#68389justlevine wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
justlevine
force-pushed
the
fix/baseconvert-division
branch
from
a006518 to
88ffc64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes several issues of string-number division in duotone-related functionality, due to the direct use of
base_convert()in the operation (which returns a numericstring).Why?
While this issue was surfaced by PHPStan (via #66693) it can be remediated independently as part of #66598
How?
absint()was used over casting for readability, since these are inline mathematical expressions.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast