Feat: Add uniform image sizes toggle to Gallery Block#68585
Open
yogeshbhutkar wants to merge 3 commits intoWordPress:trunkfrom
Open
Feat: Add uniform image sizes toggle to Gallery Block#68585yogeshbhutkar wants to merge 3 commits intoWordPress:trunkfrom
uniform image sizes toggle to Gallery Block#68585yogeshbhutkar wants to merge 3 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
|
The feature implementation is complete. I will update the test cases after the initial round of review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What, Why & How?
Adds support for maintaining uniform image sizes in gallery blocks, preventing the last image in a row from expanding to full width when there are fewer images than columns.
has-uniform-image-sizesclass support.flexproperties to maintain consistent image widths.flex: 0 0 width.Testing Instructions
Gallery Block.Image Blocksto it.uniform image sizesand notice all the image blocks now take the same sizes.Screencast
Closes: #68563