Try using popover API for navigation block (WIP)#68755
Draft
felixarntz wants to merge 13 commits intotrunkfrom
Draft
Try using popover API for navigation block (WIP)#68755felixarntz wants to merge 13 commits intotrunkfrom
felixarntz wants to merge 13 commits intotrunkfrom
Conversation
|
Size Change: -28 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
added 12 commits
February 6, 2025 13:39
…ondition to make it more obvious.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR explores using the
popoverAPI for the navigation block instead of a regular less semanticdiv.It is used for both the responsive overlay (works for both
mobileonly andalwaysconfigurations) and any submenus (works also for submenus within the responsive overlay, in which case they are always expanded).Note: So far it only works for the overlay. Still working on submenu support, which will allow getting rid of some more code.
Benefits:
z-indexnecessary (top-level is higher than anyz-indexcan be).Escapeautomatically closes the open overlay or submenus.Related: #68726