DataViews: Apply width styles to titleField in table layout#69191
Open
SainathPoojary wants to merge 2 commits intoWordPress:trunkfrom
Open
DataViews: Apply width styles to titleField in table layout#69191SainathPoojary wants to merge 2 commits intoWordPress:trunkfrom
SainathPoojary wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
d8aa755 to
8d372a4
Compare
8d372a4 to
a0e7288
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #69185
What?
Apply layout styles (width, maxWidth, minWidth) to the primary column (titleField) in DataViews table layout, consistent with how they are applied to other fields.
Why?
Currently, width-related styles from view.layout.styles are only applied to regular fields but not to the primary column (titleField). This inconsistency prevents consumers from controlling table layout shifts through min/max widths for all columns, including the primary column.
How?
Added style properties to both the table header () and table cell () elements for the primary column, applying the same width-related styles that are already supported for other fields:
The styles are conditionally applied based on the existence of the titleField and its corresponding styles in the view.layout configuration.
Testing Instructions
Screenshots