-
Notifications
You must be signed in to change notification settings - Fork 4.7k
CustomSelectControlV2: Make disabled cursor style consistent #69870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
CustomSelectControlV2: Make disabled cursor style consistent #69870
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
960afc6 to
d4af2b2
Compare
ciampo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading #63756, I'm not sure that that folks have agreed to use pointer for option elements and default (instead of not-allowed) for disabled options.
Correct, Similar to this #63816 When a consensus is made and if required then this PR can be used to solve the issue Related comment: #63756 (comment) |
What?
Follow up: #63756
In
CustomSelectControlV2items, showcursor: pointerwhen interactive andcursor: defaultwhen disabled.Why?
To make consistent with other components
Testing Instructions
npm run storybook:devCode diff
Screencast
Screen.Recording.2025-04-09.at.11.14.25.PM.mov