Enabled default block appender in gallery edit component#71236
Enabled default block appender in gallery edit component#71236dhruvikpatel18 wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
left a comment
There was a problem hiding this comment.
Thanks for contributing, @dhruvikpatel18!
Can you include before/after screenshots for the PR.
im3dabasia
left a comment
There was a problem hiding this comment.
@dhruvikpatel18, when you have a moment, please rebase the PR with trunk so we can resolve the failing CI cases.
|
@dhruvikpatel18, @im3dabasia, let's get more feedback before merging this. I checked some old issues, and it seems that having "Add new" in the toolbar was intentional. See: #21247 and #38036. While consistency is the key, not all blocks are created equal, and we should also keep that in mind. @glendaviesnz, I know it's been a while since the Gallery block refactoring, but do you have any additional details? |
|
The motivation is not bad, but the solution should ideally be more holistical. I recently revisited this issue which showed the need to ponder these features somewhat more generically, whilst still considering their context. Some instincts from that:
The unclear piece is the "Add" button, which can take the shape of a plus, the text "Add", or a fixed position appender. We have a mix of all three: can they be combined to one or is it still valid? The benefit of a Plus/Add in the toolbar is that it could always insert after the selection, or before if you hold ⌥, and this could potentially replace/remove the need for a fixed position appender that currently exists on Group. The nuance is, those all relate to either opening the block inserter directly, or inserting an empty paragraph to allow you to use the Slash command. In case of the gallery, it's different, because it does neither: it opens the media library modal. In that sense, I'd keep only the "Add" button for now, but encourage the more generic explorations for inserter improvements. |
Followed PR of: #71204 (comment)
What?
By @im3dabasia
Screenshots or screencast
Before
After