Skip to content

Fix ColorPalette to respect clearable property when deselecting colors#72283

Closed
deepakpra wants to merge 1 commit intoWordPress:trunkfrom
deepakpra:fix/colorpalette-clearable
Closed

Fix ColorPalette to respect clearable property when deselecting colors#72283
deepakpra wants to merge 1 commit intoWordPress:trunkfrom
deepakpra:fix/colorpalette-clearable

Conversation

@deepakpra
Copy link

@deepakpra deepakpra commented Oct 13, 2025

What?

Closes #71725

Fixes the behavior of the ColorPalette component when clearable={false}. Previously, deselecting a color would still trigger the clearColor function even when clearing was disabled.

Why?

The clearable property is intended to prevent a user from clearing a selected color. Without this fix, the behavior was inconsistent and did not respect the clearable setting.

See #71725 for more details.

How?

Updated the clearColor function to check the clearable value before clearing a color.

Ensured that clearing a color is only possible when clearable is set to true.

Testing

Setting clearable={false} now prevents deselecting a color.

Setting clearable={true} still allows clearing the selected color.

Existing usages of ColorPalette with clearable={true} or default behavior continue to work without issues.

@deepakpra deepakpra requested a review from ajitbohra as a code owner October 13, 2025 10:46
@github-actions
Copy link

github-actions bot commented Oct 13, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: deepakpra <deepakprajapati@git.wordpress.org>
Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: ssang <rslee@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin, New Block.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Oct 13, 2025
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @deepakpra! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@deepakpra
Copy link
Author

As clarified in this comment, the current behaviour of the clearable prop is intentional, I’m closing this PR accordingly.

@deepakpra deepakpra closed this Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ColorPalette: deselecting color should respect the clearable property

1 participant