Fix ColorPalette to respect clearable property when deselecting colors#72283
Fix ColorPalette to respect clearable property when deselecting colors#72283deepakpra wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @deepakpra! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
As clarified in this comment, the current behaviour of the |
What?
Closes #71725
Fixes the behavior of the ColorPalette component when clearable={false}. Previously, deselecting a color would still trigger the clearColor function even when clearing was disabled.
Why?
The clearable property is intended to prevent a user from clearing a selected color. Without this fix, the behavior was inconsistent and did not respect the clearable setting.
See #71725 for more details.
How?
Updated the clearColor function to check the clearable value before clearing a color.
Ensured that clearing a color is only possible when clearable is set to true.
Testing
Setting clearable={false} now prevents deselecting a color.
Setting clearable={true} still allows clearing the selected color.
Existing usages of ColorPalette with clearable={true} or default behavior continue to work without issues.