Template activation: allow editing descriptions of created templates#72791
Open
Template activation: allow editing descriptions of created templates#72791
Conversation
ellatrix
added
the
[Type] Iteration
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
9 tasks
|
Size Change: -56 B (0%) Total Size: 2.37 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8a59cff. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18915026398
|
ntsekouras
reviewed
Oct 30, 2025
| 'wp_template', | ||
| 'wp_template_part', | ||
| ].includes( postType ) | ||
| const _usedAttribute = [ 'wp_template_part' ].includes( postType ) |
Contributor
There was a problem hiding this comment.
We don't need extra checks here because this is only rendered if the checks below pass and have the edit description button, correct?
Member
Author
There was a problem hiding this comment.
So what should change? Pass usedAttribute from the parent component?
Contributor
There was a problem hiding this comment.
I didn't notice anything odd in functionality, since in order to render this for a template it should be a created templated. I think it's fine, but with so many nuances with templates I wanted to confirm.
Your hesitation though confuses me a bit. If you're not 100% sure yourself, maybe we should check it again? 🤔
priethor
added
[Type] Enhancement
tyxla
reviewed
Oct 31, 2025
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
This tests well and looks good, but the textarea needs some min-height.
Let me file a PR.
Member
See #72867 |
Contributor
|
Removing the backport label as the template activation feature has been punted to 7.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
See #71735.
Why?
These are just templates in the database of which the excerpt is editable.
How?
Registered templates (with a string ID) have to remain non-editable, while user created templates (in the database) have an integer ID and can be edited.
Testing Instructions
Site Editor > Create or duplicate a template > Document panel > Edit description
Testing Instructions for Keyboard
Screenshots or screencast