Notes: Forward mouse wheel events from floating sidebar to editor canvas#73655
Open
Notes: Forward mouse wheel events from floating sidebar to editor canvas#73655
Conversation
t-hamano
added
[Type] Enhancement
6 tasks
|
Size Change: +79 B (0%) Total Size: 2.57 MB
ℹ️ View Unchanged
|
t-hamano
changed the title
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
reviewed
Dec 1, 2025
| // Apply the scroll effect to the sidebar ref. | ||
| useEffect( () => { | ||
| if ( commentSidebarRef?.current ) { | ||
| return scrollToCanvasEffect( commentSidebarRef.current ); |
Member
There was a problem hiding this comment.
This isn't how ref effects work; you should either attach events inside the effect or pass scrollToCanvasEffect as ref to the element.
Contributor
Author
There was a problem hiding this comment.
I've made some changes based on your feedback in 71e0695. Is this approach correct?
|
Flaky tests detected in 71e0695. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19819225803
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying one approach to solving #73653.
What?
This PR propagates mouse scroll events to the editor canvas, making it easier to bring overflowing floating note content into view.
Why?
Floating notes are auto-aligned to the block position, and even if they overflow, the note sidebar is not scrollable, so you have to move your mouse cursor to the editor canvas and scroll there, which is a bit tedious.
Testing Instructions
Screencast
a3d14bd058fa3048c56c6845ab3e95ee.mp4