Skip to content

Block notes: "All notes" button visible when show template is on, even when there are no notes#73663

Closed
hbhalodia wants to merge 1 commit intoWordPress:trunkfrom
hbhalodia:fix/issue-73659
Closed

Block notes: "All notes" button visible when show template is on, even when there are no notes#73663
hbhalodia wants to merge 1 commit intoWordPress:trunkfrom
hbhalodia:fix/issue-73659

Conversation

@hbhalodia
Copy link
Contributor

What?

Closes #73659

Why?

  • PR addresses notes sidebar button to show only when adding new note or notes length is greater than 0.

How?

  • Updates, showAllNotesSidebar to use notes length and state of note to add the new note.

Testing Instructions

  1. Open post/page.
  2. Check notes button in plugin sidebar, should not be visibile if no notes.
  3. Change to show template mode, it should not show button if no notes.
  4. Add notes with both mode, post-only and template-locked, it should show notes panel and when added it should show button to see notes.

Testing Instructions for Keyboard

  • None

Screencast

Screen.Recording.2025-12-01.at.12.57.16.PM.mov

@hbhalodia hbhalodia self-assigned this Dec 1, 2025
@hbhalodia hbhalodia added [Type] Bug An existing feature does not function as intended [Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting labels Dec 1, 2025
@github-project-automation github-project-automation bot moved this to 🔎 Needs Review in WordPress 6.9 Editor Tasks Dec 2, 2025
@t-hamano t-hamano moved this from 🔎 Needs Review to 🐛 Punted to 6.9.1 in WordPress 6.9 Editor Tasks Dec 2, 2025
@github-project-automation github-project-automation bot moved this to 🔎 Needs Review in WordPress 6.9.x Editor Tasks Dec 4, 2025
@t-hamano
Copy link
Contributor

This issue has been resolved by #74577. I would like to close this PR, but thank you for your efforts!

@t-hamano t-hamano closed this Jan 13, 2026
@github-project-automation github-project-automation bot moved this from 🔎 Needs Review to ✅ Done in WordPress 6.9.x Editor Tasks Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting [Type] Bug An existing feature does not function as intended

Projects

Development

Successfully merging this pull request may close these issues.

Block notes: "All notes" button visible when show template is on, even when there are no notes

2 participants