Footnotes: Don't merge this - just a test#74275
Closed
Conversation
github-actions
bot
added
[Package] Core data
|
Size Change: +2.64 kB (+0.09%) Total Size: 3.06 MB
ℹ️ View Unchanged
|
ramonjd
force-pushed
the
try/migrate-footnotes-to-block
branch
from
c7beeaf to
4a83e1a
Compare
ramonjd
commented
Jan 5, 2026
Comment on lines
+99
to
+117
| // Don't allow footnotes inside footnotes blocks | ||
| const parentFootnotesBlocks = _getBlockParentsByBlockName( | ||
| selectedClientId, | ||
| 'core/footnotes' | ||
| ); | ||
| if ( | ||
| parentFootnotesBlocks && | ||
| parentFootnotesBlocks.length > 0 | ||
| ) { | ||
| return false; | ||
| } | ||
|
|
||
| // Also check if the selected block itself is a footnotes block | ||
| const selectedBlockName = getBlockName( selectedClientId ); | ||
| if ( selectedBlockName === 'core/footnotes' ) { | ||
| return false; | ||
| } | ||
|
|
||
| return true; |
Member
Author
There was a problem hiding this comment.
Ignore all this - I've moved it here as it seems like a bug that you can insert a footnote within a footnote
…s and migrating footnotes from post meta. This update includes logic to manage footnotes in both block attributes and post meta for backward compatibility, ensuring a seamless transition for users. Additionally, the footnotes are now initialized correctly when creating new footnotes blocks.
…emoved redundant checks for footnote order and ensured attributes are always updated for correct numbering. This enhances the handling of footnotes in both block attributes and post meta.
…ntroduced a custom hook for managing footnotes from block attributes and post meta, ensuring backward compatibility. Enhanced rendering by escaping attributes and content for improved security.
…e logic. Introduced a new function to find footnotes blocks and updated existing functions to streamline the process of updating footnotes from both block attributes and post meta. This enhances the overall functionality and ensures correct numbering in rich text attributes.
…ect usage. Added checks to disallow footnotes within other footnotes blocks and prevent selection of footnotes blocks themselves. This improves the overall integrity of footnotes handling in the editor.
…ng undo scenarios. Refactor logic to always apply footnote numbering updates and force re-renders of blocks with footnotes. This improves the integrity of footnotes management in the editor and ensures accurate display after edits.
…Simplified the migration process from post meta to block attributes, ensuring backward compatibility and correct initialization of footnotes. Introduced new utility functions for managing footnotes, enhancing overall functionality and maintainability. Added comprehensive tests to validate the migration and update processes.
…ooks for extracting and merging footnotes during paste operations, ensuring proper handling and numbering of footnotes. Updated the private APIs to include new footnotes utilities, enhancing overall footnotes management in the editor.
ramonjd
force-pushed
the
try/migrate-footnotes-to-block
branch
from
4a83e1a to
fb1bdc6
Compare
…numbering.js - Reconstructs innerHTML with the current data-fn ID instead of preserving stale IDs. This is essential for any footnote ID updates to work correctly.
Member
Author
|
This was just a POC to identify issues/pros/cons/delicious sandwich fillings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧
This PR is just to test some code. It's not to be merged. What are you even doing here, looking at it? Close your eyes! The horror!
🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧 🚧
What?
Migrates footnotes from post meta to block attributes. Footnotes are now stored in the
core/footnotesblock'sfootnotesattribute instead of post meta.useMigrateFootnoteshook to migrate footnotes from meta to block attributes on block loadupdateFootnotesFromMetato use block attributes when available, falling back to meta for backward compatibilityWhy?
This makes the footnotes part of the post so:
How?
Testing Instructions
npm run test:unit packages/block-library/src/footnotes packages/core-data/src/footnotesScreenshots or screencast
Kapture.2025-12-31.at.13.23.59.mp4