Layout: Fix blockGap resolution for block style variations#74504
Layout: Fix blockGap resolution for block style variations#74504AtharvaSagane wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @AtharvaSagane! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
Hi! This is my first PR. Could a maintainer please add the [Type] Bug and [Feature] Layout labels to this? Thank you! |
Currently, the layout engine ignores blockGap values defined within block style variations because it only checks block attributes and global styles. This PR updates gutenberg_render_layout_support_flag to resolve styles through WP_Theme_JSON_Resolver before falling back to global settings.
Testing Instructions:
Create a Block Style Variation for the Group block in theme.json that sets a specific blockGap (e.g., 0px).
Add a Group block to a page and apply this variation.
Verify in the frontend inspector that the child elements receive the variation's gap value instead of the global default.