Skip to content

Layout: Fix blockGap resolution for block style variations#74504

Closed
AtharvaSagane wants to merge 2 commits intoWordPress:trunkfrom
AtharvaSagane:fix/layout-engine-variation-gap
Closed

Layout: Fix blockGap resolution for block style variations#74504
AtharvaSagane wants to merge 2 commits intoWordPress:trunkfrom
AtharvaSagane:fix/layout-engine-variation-gap

Conversation

@AtharvaSagane
Copy link

Currently, the layout engine ignores blockGap values defined within block style variations because it only checks block attributes and global styles. This PR updates gutenberg_render_layout_support_flag to resolve styles through WP_Theme_JSON_Resolver before falling back to global settings.

Testing Instructions:

Create a Block Style Variation for the Group block in theme.json that sets a specific blockGap (e.g., 0px).

Add a Group block to a page and apply this variation.

Verify in the frontend inspector that the child elements receive the variation's gap value instead of the global default.

@github-actions
Copy link

github-actions bot commented Jan 10, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: AtharvaSagane <atharvasagane@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @AtharvaSagane! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jan 10, 2026
@AtharvaSagane
Copy link
Author

Hi! This is my first PR. Could a maintainer please add the [Type] Bug and [Feature] Layout labels to this? Thank you!

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Feature] Layout Layout block support, its UI controls, and style output. [Feature] Block Style Variations Issues or PRs that are related to the style variations for blocks labels Jan 11, 2026
@t-hamano t-hamano linked an issue Jan 11, 2026 that may be closed by this pull request
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Sorry, but since #74513 has already been submitted, I would like to close this PR.

@t-hamano t-hamano closed this Jan 11, 2026
@AtharvaSagane AtharvaSagane deleted the fix/layout-engine-variation-gap branch January 12, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Block Style Variations Issues or PRs that are related to the style variations for blocks [Feature] Layout Layout block support, its UI controls, and style output. First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Global blockGap property is not overridable in style variations

2 participants