Components: remove "text-wrap: balance" fallback from Text#75089
Components: remove "text-wrap: balance" fallback from Text#75089
Conversation
packages/components/CHANGELOG.md
Outdated
There was a problem hiding this comment.
Should this be considered breaking change? 🤔
There was a problem hiding this comment.
To me, this change seems like a bug fix.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -6 B (0%) Total Size: 3 MB
ℹ️ View Unchanged
|
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I think this change makes sense to me. Pinging @WordPress/gutenberg-components for visibility
|
@simison Can you run the following command to update the snapshots? |
|
👍 👍 |
74e59e0 to
33f9148
Compare
Co-authored-by: simison <simison@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
Co-authored-by: simison <simison@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
What?
Spin off from #74907
Removes the
text-wrap: balancefallback from theTextcomponent. The component now uses onlytext-wrap: prettywithout theSafariFirefox fallback.The code says it was Safari fallback, but actually it's Firefox which doesn't support
pretty:Why?
During discussion in PR #74907 about removing
text-wrap: balancefallbacks, it was noted that theTextcomponent also includes this fallback pattern. Thetext-wrap: balancefallback was originally added for Safari compatibility.balancecreates visually more opinionated layout compared topretty, which pretty much only handles typographic orphans. Balance is causing issues with non-Latin languages like Japanese:text-wrap: balance)text-wrap: balance)How?
The
Textcomponent now only includestext-wrap: pretty.Testing Instructions
Text(like labels, descriptions, etc.) still renders correctly without any visual regressions. You can browse Site editor pages to see it in action.Testing Instructions for Keyboard
None.
Screenshots or screencast
None.