DataViews: Hide table headers when there is no data.#75336
Closed
StevenDufresne wants to merge 1 commit intotrunkfrom
Closed
DataViews: Hide table headers when there is no data.#75336StevenDufresne wants to merge 1 commit intotrunkfrom
StevenDufresne wants to merge 1 commit intotrunkfrom
Conversation
Ref: DOTMSD-1079
|
Size Change: -7 B (0%) Total Size: 2.99 MB
ℹ️ View Unchanged
|
Contributor
Author
|
Going with #74572. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements: #75272
What?
Hide the table layout content (including headers) when there is no data, matching the existing behavior of grid, list, and activity layouts.
Why?
When DataViews table layout receives an empty data array, it renders an empty table with headers. This is confusing because headers imply there are results, column widths can collapse/jitter, and header interactions (sort/menus) appear usable but operate on nothing.
The grid, list, and activity layouts already hide their structure when empty — the table was the only outlier.
How?
Added an early return in ViewTable when !hasData that renders only the empty state or loading spinner, skipping the entire
element (colgroup, thead, tbody). Also:Testing Instructions
Testing Instructions for Keyboard