Merged
Conversation
mikachan
requested review from
ajitbohra,
fabiankaegy and
juanmaguitar
as code owners
mikachan
added
[Type] Enhancement
13 tasks
|
Size Change: -1.91 kB (-0.03%) Total Size: 6.84 MB
ℹ️ View Unchanged
|
t-hamano
reviewed
Feb 20, 2026
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
I agree that we should not introduce a custom UI for now.
I also suggest removing hard-coded colors and styles.
- Apply only offsets to outlines. Use browser default styles for outline width, style, and color.
- Don't apply hover styles.
- Don't rely on global style presets.
What do you think about making the following changes?
diff --git a/packages/block-library/src/tabs-menu-item/style.scss b/packages/block-library/src/tabs-menu-item/style.scss
index 4d18b9d4d28..b61fb705b64 100644
--- a/packages/block-library/src/tabs-menu-item/style.scss
+++ b/packages/block-library/src/tabs-menu-item/style.scss
@@ -15,8 +15,7 @@
-webkit-appearance: none;
margin: 0;
- padding-block: var(--wp--preset--spacing--20, 0.5em);
- padding-inline: var(--wp--preset--spacing--30, 1em);
+ padding: 0.5em 1em;
// Inherit typography from parent
font-size: inherit;
@@ -27,20 +26,10 @@
text-transform: inherit;
text-align: inherit;
- &:focus {
- outline: none;
- }
-
&:focus-visible {
- outline: 2px solid #000;
outline-offset: 2px;
}
- &:hover {
- background-color: #eaeaea;
- color: #000;
- }
-
&[aria-selected="true"],
&.is-active {
background-color: #000;
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
Author
Sounds good! I like the idea of keeping the styling as minimal as possible for now. I've pushed those changes in e8d4aa2. |
scruffian
reviewed
Feb 20, 2026
scruffian
approved these changes
Feb 20, 2026
Contributor
scruffian
left a comment
scruffian
left a comment
There was a problem hiding this comment.
Left a few thoughts but nothing that should stop us merging.
Contributor
|
Looks like there are some things in block-library/src/tabs-menu-item/editor.scss that also need to be removed. |
|
Flaky tests detected in 963a692. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22234020622
|
Member
Author
|
Thanks both! Will get this merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Addresses part of the discussion in #73230 for removing the ad-hoc styling controls from the Tab Menu Item block.
Why?
Ideally, no blocks included in the block library should use their own custom solutions for styling, and instead should use shared tools available to all blocks.
In this case, in the near future, it would be great if this block could use a solution based on the work in #75627.
How?
Removes the following styling controls from the Tab Menu Item block: activeBackgroundColor, activeTextColor, customActiveBackgroundColor, customActiveTextColor, customHoverBackgroundColor, customHoverTextColor, hoverBackgroundColor, hoverTextColor
Testing Instructions
Screenshots or screencast