Merged
Conversation
Mamaduka
added
the
[Type] Automated Testing
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
|
||
| // Save the reusable block and update the post. | ||
| await editorTopBar.getByRole( 'button', { name: 'Save' } ).click(); | ||
| const entitiesSaveButton = this.page |
Contributor
There was a problem hiding this comment.
Should this be page instead of this.page?
Member
Author
There was a problem hiding this comment.
Good catch, leftover from copy-pasta 🍝
andrewserong
approved these changes
Feb 20, 2026
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
Odd that the categories are popping up there, but I like this approach, seems like a pragmatic fix to ensure this test is resilient to the multi-entity saving flow 👍
LGTM if they pass!
Contributor
I am not sure either, but it seems likely. I also cannot reproduce locally, ever. We intend to disable RTC by default in the morning in WordPress#trunk, after which this test should start passing again. Then we can take a closer look with less urgency. I'd like to understand the root cause with confidence. |
Member
Author
|
I inspected the requests that come with the trace. I don't see anything that modifies the category. Users can't edit term records in the editor, which means I can't even reproduce the exact case manually if I wanted to. I think this signals that the problem is coming from somewhere else. |
|
Size Change: 0 B Total Size: 6.84 MB ℹ️ View Unchanged
|
Mamaduka
added
the
Backport to WP 7.0 Beta/RC
This was referenced Feb 20, 2026
Member
Author
|
@ellatrix, it looks like automatic cherry-picking didn't work. Action didn't report any failures; I'm not sure what happened. |
Member
|
That's fine, we don't need it anymore :) |
ellatrix
removed
the
Backport to WP 7.0 Beta/RC
ellatrix
added a commit
that referenced
this pull request
Feb 20, 2026
scruffian
pushed a commit
that referenced
this pull request
Feb 23, 2026
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: chriszarate <czarate@git.wordpress.org>
scruffian
pushed a commit
that referenced
this pull request
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
PR tries to fix the failing patterns test. Based on trace artifacts, the test now includes a multi-entity saving flow that it didn't account for.
A post category is also modified, which causes the flow change. I'm not sure if it's related to RTC being enabled by default, and I'm having trouble reproducing it locally. cc @chriszarate
Testing Instructions
Screenshot