Dialog: Add legacy z-index compatibility#75874
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 6.84 MB ℹ️ View Unchanged
|
Member
Author
|
By the way, currently it's difficult (impossible?) to override the z-indexes for YAGNI for now, but at some point we may need to tweak something, like have |
Contributor
|
Could we:
Or even be set on the root and passed to both popup and backdrop via context? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds a
--wp-ui-dialog-z-indexCSS custom property to the Dialog component's backdrop and popup, following the same pattern used by other@wordpress/uicomponents (Combobox, Select, Tooltip).Why?
Gutenberg manages stacking with explicit z-index values. Without this, the Dialog has no z-index hook, making it impossible for consumers to ensure correct stacking when the Dialog coexists with legacy
@wordpress/componentspopovers or modals.The CSS variable defaults to
initial(no z-index), so there's no behavioral change unless a consumer explicitly sets the variable — e.g., via a global compatibility layer that maps it to the legacy.components-modal__screen-overlayz-index.How?
z-index: var(--wp-ui-dialog-z-index, initial)to both.backdropand.popupinstyle.module.css. Both need the z-index because they're siblings inside the portal (unlike the legacy Modal where the frame is a child of the overlay).Testing Instructions
No visual changes.