Add previews for style variation transforms#75889
Merged
tellthemachines merged 1 commit intotrunkfrom Feb 25, 2026
Merged
Conversation
tellthemachines
added
[Type] Enhancement
|
Size Change: +80 B (0%) Total Size: 6.84 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Feb 25, 2026
Member
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
LGTM. It matches existing transform previews behaviour. Nice addition!
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
|
This is a really nice enhancement :) |
Contributor
|
Nice. Great improvement ✨ One thing that looks odd to me is that the popover has a label on top that preview in the inspector does not, but instead a label at the bottom indicating the preview title. I don't know the rationale behind this decision, but both could be the same. Although popover elements over the canvas also have a darker border, but that seems consistent with where the element is triggered from.
On the other hand, and something that does not block this PR, is that the way of browsing styles from the toolbar is different if you're in the pattern root block or in an internal one. pattern.and.block.interaction.to.browse.styles.mp4The heuristic in both could be simplified and the same, although the pattern preview in the inspector does not render the pattern with the styles previewed. |
Contributor
Author
Which do you think we should standardise on? I'm happy to do that as a follow-up. Something else I've noticed is that the previews from the block toolbar don't activate on focus, whereas the inspector ones do. I'll look into fixing that too. |
Contributor
I like the preview image alone, without any label on top or at the bottom. In cases where the background preview is white, like in the Canvas example, the label blends with the preview and seems as part of the preview. I asked Cursor for a11y requirements that |
This was referenced Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to this comment on the absence of previews for style transforms.
Testing Instructions