Conversation
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @jasmussen! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -14 B (0%) Total Size: 6.84 MB
ℹ️ View Unchanged
|
oandregal
left a comment
There was a problem hiding this comment.
The divider has been introduced in the 7.0 cycle, so if we aim to remove it I understand this PR should be backported for 7.0 beta. I'll add the label so it gets automatically backported.
|
Something is off with GitHub. I merged, it timed out, but trunk shows the PR is actually merged. So it seems the GH UI is out of sync. Not sure how that happened. |
|
There was a conflict while trying to cherry-pick the commit to the wp/7.0 branch. Please resolve the conflict manually and create a PR to the wp/7.0 branch. PRs to wp/7.0 are similar to PRs to trunk, but you should base your PR on the wp/7.0 branch instead of trunk. |
|
Apologies, folks, not sure why this is happening. Would appreciate if someone could help. |
|
I see the PR was merged fine in trunk. The conflicts probably have to do with conflicts in the changelog.md file. I'll look into that and will backport this one manually. Edit: backport at #75908 |
Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
|
Thank you! |
|
When manually cherry-picking, we should also update the labels manually |
What?
Followup to #72840 (comment).
Removes the divider that was separating quick actions from the remaining actions that was previously added in #72866, but keeps the change sort order.
Why?
The motivation seems valid: there's no clear semantic reason for why the separator is there. Intrinsically I understand why it's there, it separates quick actions from other actions, the hope was to explain why the same actions are available both as quick actions and in the menu. But in practice the separator mostly feels like a source of confusion.
Testing Instructions
Try dataviews, click the ellipsis menu. Before:
After: