Preserve note selection on browser tab switch#75955
Merged
Mamaduka merged 1 commit intoWordPress:trunkfrom Feb 27, 2026
Merged
Conversation
Check document.hasFocus() in onBlur handlers so that switching browser tabs or windows does not deselect the active note, preventing unintended state resets.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
|
@Mamaduka! When you have a moment, I'd appreciate a review on this. cc: @joedolson |
Mamaduka
approved these changes
Feb 27, 2026
Member
Mamaduka
left a comment
There was a problem hiding this comment.
Thanks, @im3dabasia! This looks good ✅
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original code/commit is by @/adamsilverstein
What?
Closes #75640
Prevents notes from collapsing when the browser window or tab loses focus.
Why?
Currently, switching to another window or tab triggers an onBlur event that deselects the active note. This creates friction for users who need to reference external documents while writing notes.
How?
Added a check for
document.hasFocus()within theonBlurhandlers in add-comment.js and comments.js.Testing Instructions
Screenshots or screencast
Screencast
Before
Screen.Recording.2026-02-27.at.5.25.48.PM.mov
After
Screen.Recording.2026-02-27.at.5.16.02.PM.mov
Extra video ref: The popover closes when focus is lost within the same tab, but it stays open when switching to other tabs or apps.
Screen.Recording.2026-02-27.at.5.30.36.PM.mov