Remove Core's full-page render interceptors for boot-based pages#76036
Merged
Remove Core's full-page render interceptors for boot-based pages#76036
Conversation
…igation Core WP 7.0 registers admin_init interceptors for boot-based pages that fire before Gutenberg's (same priority, registered earlier in wp-settings.php). These read menu items from Core's globals instead of Gutenberg's, resulting in empty navigation sidebars. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
|
All pages work except for Fonts which gives this error: |
Contributor
|
Something I don't understand is where wp_site_editor_v2_intercept_render, wp_font_library_intercept_render and wp_connectors_intercept_render are defined... |
Contributor
Author
|
@scruffian these are defined in Core. I can't reproduce your font library issue though |
youknowriad
added
[Type] Bug
Contributor
Author
|
@scruffian Ah sorry, I do reproduce the font library issue on the extensible site editor, I think the menu item needs to be removed from there but that's a separate issue. Let's ignore for now. |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Actually, I just pushed the font library menu item removal from there. It's not supposed to be there at the moment. |
Contributor
|
The icon for fonts is still there... |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Size Change: -733 B (-0.01%) Total Size: 6.87 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e21fd1a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22577821507
|
jeryj
approved these changes
Mar 2, 2026
Contributor
jeryj
left a comment
jeryj
left a comment
There was a problem hiding this comment.
Tested on Playground with WP 7.0 beta 2 release and WP trunk, and the sidebar menu items appear now. Thanks for the bug fix!
I think I found an unrelated bug: After navigating to Patterns or another location that doesn't include the site preview, the site preview will not load when going to the "Home" route.
Steps:
- Go to Site Editor
- Click Patterns. Wait for load to complete
- Click Home. Site preview will not load.
scruffian
approved these changes
Mar 3, 2026
Contributor
scruffian
left a comment
scruffian
left a comment
There was a problem hiding this comment.
Looks good now, thanks!
alecgeatches
pushed a commit
to Automattic/gutenberg
that referenced
this pull request
Mar 3, 2026
…dPress#76036) * Remove Core's full-page render interceptors to fix broken sidebar navigation Core WP 7.0 registers admin_init interceptors for boot-based pages that fire before Gutenberg's (same priority, registered earlier in wp-settings.php). These read menu items from Core's globals instead of Gutenberg's, resulting in empty navigation sidebars. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Remove Fonts menu item from site editor v2 sidebar Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Remove fontList icon from edit-site-init Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
admin_initinterceptors (wp_site_editor_v2_intercept_render,wp_font_library_intercept_render,wp_connectors_intercept_render) so Gutenberg's versions run insteadOn WP 7.0-beta2, Core now ships its own full-page render interceptors for boot-based pages. These are registered at
wp-settings.php(line 248), before plugins load, so they fire before Gutenberg's at the sameadmin_initpriority. Core's render reads menu items from$wp_site_editor_v2_menu_items, but Gutenberg stores them in$gutenberg_site_editor_v2_menu_items— a different global — resulting in emptymenuItems: []and a broken sidebar navigation.Test plan
/wp-admin/admin.php?page=site-editor-v2🤖 Generated with Claude Code