Conversation
ockham
added
[Type] Bug
|
Size Change: +94 B (0%) Total Size: 6.87 MB
ℹ️ View Unchanged
|
ockham
requested review from
ajitbohra,
nerrad,
ntwb and
tellthemachines
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
|
cc/ @ellatrix for possible inclusion in WP 7.0 Beta 3 |
talldan
approved these changes
Mar 3, 2026
Contributor
talldan
left a comment
talldan
left a comment
There was a problem hiding this comment.
This is working nicely, thanks for fixing!
ockham
deleted the
fix/auto-inspector-controls-should-reflect-bound-attribute-values
branch
github-actions
bot
removed
the
Backport to WP 7.0 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Mar 3, 2026
…#76040) For PHP-only registered blocks, if an attribute is bound, have the attribute control in the block inspector reflect the bound value. Co-authored-by: ockham <bernhard-reiter@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/7.0 branch to get it included in the next release: 7acb5ec |
alecgeatches
pushed a commit
to Automattic/gutenberg
that referenced
this pull request
Mar 3, 2026
…WordPress#76040) For PHP-only registered blocks, if an attribute is bound, have the attribute control in the block inspector reflect the bound value. Co-authored-by: ockham <bernhard-reiter@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org>
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
For PHP-only registered blocks, if an attribute is bound, have the attribute control in the block inspector reflect the bound value.
Why?
In #75543 (comment), it was pointed out that if an attribute was connected to a Block Bindings source, those controls didn't reflect bound attribute values. This PR fixes the issue.
How?
By essentially applying the same fix as #72096.
This is the second instance (I'm aware of) of UI controls used to display (and modify) block attribute values that didn't take Block Bindings into account. In an ideal world, we might want to absorb the relevant logic into
getBlockAttributes(). Unfortunately, Block Bindings require knowledge of a given block's block context, so it's not that straight-forward.Testing Instructions
npm run wp-env-test).localhost:8889), activate the "Gutenberg Test Block Bindings" and "Gutenberg Test Server-Side Rendered Block" plugins.titleattribute to the Post Meta source'stext_custom_fielditem.countattribute to the Post Meta source's "Integer custom field" item.spacingattribute to the Post Meta source's "Number custom field" item.showEmojisattribute to the Post Meta source's "Boolean custom field" item.Additionally:
npm run test:e2e -- test/e2e/specs/editor/plugins/server-side-rendered-block.spec.js.git revert 54e664ce69ab7af7fc0626ff7f2d44b00cc04c8c.Screenshots or screencast
Follow-up
It was mentioned in #75543 (comment) that it is currently possible to bind a block attribute whose values are constrained by an
enumto an unconstrained block bindings source. I'll follow up with a PR to fix that issue.