RTC: Prevent duplicate poll cycles#76059
Merged
chriszarate merged 2 commits intotrunkfrom Mar 3, 2026
Merged
Conversation
chriszarate
added
[Type] Bug
chriszarate
added
the
Backport to WP 7.0 Beta/RC
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
maxschmeling
approved these changes
Mar 2, 2026
|
Size Change: -9 B (0%) Total Size: 6.87 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in cf7a709. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22599375955
|
ingeniumed
approved these changes
Mar 3, 2026
gziolo
pushed a commit
that referenced
this pull request
Mar 3, 2026
* Prevent duplicate poll cycles * Fix type issue in test Co-authored-by: chriszarate <czarate@git.wordpress.org> Co-authored-by: maxschmeling <maxschmeling@git.wordpress.org>
ellatrix
added
Backport to WP 7.0 Beta/RC
github-actions
bot
removed
the
Backport to WP 7.0 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Mar 3, 2026
* Prevent duplicate poll cycles * Fix type issue in test Co-authored-by: chriszarate <czarate@git.wordpress.org> Co-authored-by: maxschmeling <maxschmeling@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/7.0 branch to get it included in the next release: e767b95 |
alecgeatches
pushed a commit
to Automattic/gutenberg
that referenced
this pull request
Mar 3, 2026
* Prevent duplicate poll cycles * Fix type issue in test Co-authored-by: chriszarate <czarate@git.wordpress.org> Co-authored-by: maxschmeling <maxschmeling@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fix a race condition in the RTC polling manager that causes multiple concurrent poll cycles.
Why?
PR #75843 introduced
handleVisibilityChangeto back off polling when the browser tab is inactive. When the tab becomes visible again, it callspoll()immediately so collaborator updates appear without delay. However, this can spawn a duplicate poll cycle when an HTTP request is already in-flight, leading to multiple concurrent poll chains that multiply over time.How?
The root cause is that
handleVisibilityChangecheckedisPollingbefore calling poll(), butisPollingis a "has polling ever started" flag. It’struefor the entire lifetime of the polling loop, not just while a request is in-flight. So the guard didn’t prevent callingpoll()during an activepostSyncUpdaterequest.Testing Instructions