DateTimePicker: Fix day text wrapping#76084
Merged
ntsekouras merged 2 commits intotrunkfrom Mar 3, 2026
Merged
Conversation
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 6.87 MB ℹ️ View Unchanged
|
ntsekouras
approved these changes
Mar 3, 2026
Contributor
ntsekouras
left a comment
ntsekouras
left a comment
There was a problem hiding this comment.
Thank you! Let's get this in for now and will check more if there are any other issues with the original PR. If any important issues are discovered we should probably revert..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #76071 (comment)
What?
The addition of
word-break: break-wordto theButtoncomponent caused unintended wrapping in theDateTimePickercomponent.The text was probably already overflowing, and
word-break: break-wordjust exposed the problem.Why?
I suspect the text had already been overflowing before, and
word-break: break-wordseemed to expose the issue.How?
The padding isn't necessary in the first place, so we'll remove it.
Testing Instructions
Screenshots or screencast