Perf tests: Await all test actions in a single closure to prevent parallelism#76224
Open
chriszarate wants to merge 4 commits intotrunkfrom
Open
Perf tests: Await all test actions in a single closure to prevent parallelism#76224chriszarate wants to merge 4 commits intotrunkfrom
chriszarate wants to merge 4 commits intotrunkfrom
Conversation
chriszarate
added
[Type] Automated Testing
alecgeatches
approved these changes
Mar 6, 2026
Contributor
There was a problem hiding this comment.
This seems like a reasonably safe fix for the currently broken performance tests. If the cause is a huge post with multiple users non-intentionally, you're right that this isn't the point of the original test. It's probably not a regression but a unintentional comparison between different situations.
We should still follow-up to create an intentional real-time collaboration performance test around this same scenario, because there is a different real-time collaboration performance issue to diagnose.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 6.88 MB ℹ️ View Unchanged
|
ingeniumed
approved these changes
Mar 6, 2026
|
Flaky tests detected in 9481208. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22748790169
|
chriszarate
force-pushed
the
fix/site-editor-perf-tests
branch
from
2f80229 to
57b45ef
Compare
chriszarate
force-pushed
the
fix/site-editor-perf-tests
branch
2 times, most recently
from
80552a8 to
9481208
Compare
chriszarate
force-pushed
the
fix/site-editor-perf-tests
branch
from
9481208 to
0d647ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Await all test actions in a single closure to prevent parallelism.
Why?
Even with a single worker (the default), I observed multiple tests running at once due to how the loop is constructed. The
testfunction is called immediately and it's up to the test runner (Playwright) to determine when to execute the callback. In my local testing, I observed tests running in parallel, which causes multiple collaborators to join the session, overload the test server, and subvert the intention of the test.How?
Move the loop so that it executes in a single
testandawaits each iteration.Testing Instructions