Focus utilities: Keep focus ring on aria-disabled buttons during :active#76858
Closed
Focus utilities: Keep focus ring on aria-disabled buttons during :active#76858
Conversation
Buttons using `aria-disabled` (instead of native `disabled`) still receive the `:active` pseudo-state when Space is pressed. The `:not(:active)` selector in `outset-ring--focus-except-active` was hiding the focus ring, giving a false impression of interactivity. Add companion selectors that preserve the outline when `[aria-disabled="true"]` is active, for both the direct and focus-within variants. Made-with: Cursor
Made-with: Cursor
|
Size Change: +64 B (0%) Total Size: 7.69 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in bbbdd83. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23641938329
|
Contributor
Author
|
Closing since this fix was mostly curing a symptom rather than the real cause — which was linked to how |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Keep the focus ring visible on
aria-disabledbuttons when they enter the:activepseudo-state (e.g. when pressing Space).Why?
Buttons using
aria-disabled(instead of nativedisabled) still receive the:activepseudo-state. The:not(:active)selector inoutset-ring--focus-except-activewas hiding the focus ring on Space press, giving a false impression that the button is interactive and responding to the click.How?
Add companion selectors that preserve the outline when
[aria-disabled="true"]is active, for both the direct (.outset-ring--focus-except-active) and focus-within (.outset-ring--focus-within-except-active) variants.Testing Instructions
npm run storybook:devDialogwith aDialog.Actionthat hasloading={true})Unit tests
Use of AI Tools
Cursor + Claude Opus 4.6. All code was reviewed and validated by the author.