fixed submenu-overlay

[adithya-naik]

What?

Closes #76887 #44346

Why?

Solves the submenu being opening up by default.

How?

Fixed CSS for Navigation Component

Testing Instructions

1. Appearance -> Editor -> Patterns -> Header
2. Navigation -> Settings
3. Settings "Overlay Template": Default
4. Change Settings "Display", "Overlay"

Testing Instructions for Keyboard

Screenshots or screencast

Before	After

Use of AI Tools

[github-actions]

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

• Required label: Any label starting with [Type].
• Labels found: [Status] Blocked, [Package] Block library, [Block] Navigation, First-time Contributor.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

[github-actions]

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

• Required label: Any label starting with [Type].
• Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @adithya-naik.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: adithya-naik.

Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: hagege <hage@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @adithya-naik! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

[adithya-naik]

Previously the icon is not visible.

After changes :

Screenshot

[t-hamano]

Thanks for the PR!

If I understand correctly, the current behavior is intentional. Before we move forward with this PR, let's first confirm if the current behavior is as expected.

[adithya-naik]

Thanks for the PR!

If I understand correctly, the current behavior is intentional. Before we move forward with this PR, let's first confirm if the current behavior is as expected.

Thanks for the clarification.

Based on the issue description (#76887), the current behavior does not seem intentional. When using the Default overlay template, the submenu is always expanded on the front end, regardless of the selected Submenu Visibility setting (Hover or Click).
This appears to contradict the expected behavior, where the submenu should remain collapsed unless triggered by user interaction.

Please let me know if this behavior is expected by design. If so, I’m happy to revisit the approach; otherwise, this PR aims to align the behavior with the expected functionality.

[t-hamano]

@adithya-naik Let's wait for responses from those who are knowledgeable about this feature. #76887 (comment)

[carolinan]

It is unrelated to the overlay feature.
It is worth exploring, but it is important to consider that different users will have different needs and different expectations.
A CSS only change like this would change the current behavior for all sites that uses this block, and for many it would be an unexpected breaking change.

Also, it would need some more work on the design, so that the icon is positioned better and menu items don't overlap.

[adithya-naik]

It is unrelated to the overlay feature.
It is worth exploring, but it is important to consider that different users will have different needs and different expectations.
A CSS only change like this would change the current behavior for all sites that uses this block, and for many it would be an unexpected breaking change.

Also, it would need some more work on the design, so that the icon is positioned better and menu items don't overlap.

Sure @carolinan , Thanks for the suggestions and I will be raising a PR in short time.

[t-hamano]

@adithya-naik, It feels like we need to discuss and confirm what the actual problem is and what the correct behavior should be before we can actually write or change code. For now, let's close this PR and continue the discussion on #44346.

[adithya-naik]

Solves #52505