UI: Use Link component in details story example#76997
Merged
Conversation
Made-with: Cursor
jameskoster
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 7.73 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 7199f41. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23891505945
|
mirka
approved these changes
Apr 2, 2026
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
|
Merging to dedupe these changes from #76783. |
mirka
added
Storybook
adamsilverstein
pushed a commit
that referenced
this pull request
Apr 7, 2026
Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates the shared
DETAILS_EXAMPLEused inWithDetailsstories to use theLinkcomponent instead of a plain<a>element.Why
The details story is meant to demonstrate rich content within the
detailsprop. Using the design system's ownLinkcomponent rather than a raw anchor tag better represents how consumers should compose these components together in practice.How
Linkcomponent intopackages/ui/src/form/stories/shared.tsx.<a>element with<Link>inDETAILS_EXAMPLE.To test
npm run storybook.Linkrather than the plaina.