HStack, VStack: Mark as not recommended for use#77041
Conversation
|
Size Change: 0 B Total Size: 7.74 MB ℹ️ View Unchanged
|
aduth
left a comment
There was a problem hiding this comment.
It's nice to see us recommend these new components! Do we want to follow-up with changes like updating use-new-components.js to explicitly discourage @wordpress/components in favor of this component? I also can't recall if we have any more documentation that discourages @wordpress/ui as "not quite ready" (I recall the previous AGENTS.md guidance we had in the package was like this)
| function Example() { | ||
| return ( | ||
| <VStack spacing={4}> | ||
| <Stack direction="column" gap="lg"> |
There was a problem hiding this comment.
We should update the import statements above.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 1283d9c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24031421947
|
Yes, this will be done separately.
Tweaked in 1283d9c |
* HStack, VStack: Mark as not recommended for use * Fix import * Tweak wording in AGENTS file Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: aduth <aduth@git.wordpress.org>
What?
Updates Storybook component status for
HStackandVStackfrom stable to not recommended, with a note to useStackfrom@wordpress/uiinstead.Also aligns related docs and examples.
Why?
This should ultimately be enforced with the
use-recommended-componentslint rule. This PR is just a preliminary step to update the docs.Testing Instructions
HStack,VStack, andFlexand confirm the status badges/notes match the intent.Use of AI Tools
Composer 2