Do not merge: run e2e tests for 7.0 without Gutenberg active#77066
Open
Do not merge: run e2e tests for 7.0 without Gutenberg active#77066
Conversation
ellatrix
requested review from
ajitbohra,
kevin940726,
nerrad and
ntwb
as code owners
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ellatrix
changed the title
ellatrix
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 7.61 MB ℹ️ View Unchanged
|
This reverts commit ccf5474.
Core exits iframe mode when a v1 block is added, while Gutenberg keeps it iframed. Use isGutenbergPluginActive to assert the correct behavior. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- post-meta: Block Fields experiment requires plugin - save-entity-record-template-compat: active_templates experiment requires plugin - cross-origin-isolation: DIP header requires plugin (client-side media processing) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ellatrix
force-pushed
the
try/e2e-test-guards-v2
branch
from
9869078 to
c2ab903
Compare
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Core registers the connectors page at options-connectors.php while Gutenberg uses options-general.php?page=options-connectors-wp-admin. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ellatrix
force-pushed
the
try/e2e-test-guards-v2
branch
from
dc3af6a to
7bc4a74
Compare
The abilities API endpoints are Gutenberg-only and not present in core, so the expected preload requests differ. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Empty state: also remove core's filter function - JS extensibility: match both core and Gutenberg hook suffixes Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ellatrix
force-pushed
the
try/e2e-test-guards-v2
branch
from
18a9009 to
16810f7
Compare
WordPress strips .php from the slug when computing hook suffixes, so core's hook is settings_page_options-connectors, not settings_page_options-connectors.php. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ellatrix
force-pushed
the
try/e2e-test-guards-v2
branch
from
d17be70 to
8d6ebb2
Compare
|
Flaky tests detected in 8d6ebb2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24093883211
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Make e2e tests runnable without the Gutenberg plugin active.
Previously: #74536
Why?
It would be nice if all e2e tests can run on core without the plugin active. This requires a few tests to be skipped or adjusted.
How?
.wp-env.jsonand.wp-env.test.jsonisGutenbergPluginActivefixture to e2e test utilssetGutenbergExperimentsreturnbooleanindicating successNotes
collaboration-notes.spec.tsfailures are legitimate — we still need to backport some collaboration code to core for those to pass.preload.spec.js— preload expectations differ without Gutenberg, still to investigatepost-content-focus-mode.spec.js— timeout, possibly flaky, still to investigate