Search block: Derive 'isSearchFieldHidden' value#77082
Merged
Conversation
Mamaduka
added
[Type] Bug
Mamaduka
requested review from
ajitbohra,
fabiankaegy and
juanmaguitar
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -112 B (0%) Total Size: 7.74 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in 7f6ae24. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24069387453
|
ramonjd
approved these changes
Apr 7, 2026
Member
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
LGTM.
Insert the Search block.
Here were my test steps 😄
- Set button position to "Button only"
- Confirm no extra undo steps are created just from selecting/deselecting the block
- Load a post that already has a Search block saved with the old isSearchFieldHidden attribute, and confirm it still renders and edits correctly
2026-04-07.16.57.33.mp4
I don't think it's a big deal to lose the click + close, but for space-faring meta humans in the future returning to look at this PR to learn from our prehistoric ways, it might be good to mention in the PR. 🚀
Member
Author
|
Thanks for the review, @ramonjd! |
adamsilverstein
pushed a commit
that referenced
this pull request
Apr 7, 2026
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #53174.
Introduced via #50487.
PR removes unnecessary attribute sync via effects, which was creating unwanted undo history entries. Use a simple derived state to apply editor-only classes.
I know this isn't 100% match to previous behavior, but expanding the block on selection is what we need most of the time.
What's different from trunk?
Clicking on the search button in the block editor canvas will no longer collapse/example the input field.
How?
I came to the same conclusion as @t-hamano in #52519 (comment).
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2026-04-07.at.09.51.31.mp4
Use of AI Tools
None.