Remove remaining esModuleInterop usage#77095
Merged
manzoorwanijk merged 2 commits intotrunkfrom Apr 7, 2026
Merged
Conversation
Remove `esModuleInterop` from `bin/tsconfig.json` and `packages/wp-build/tsconfig.json`, and remove the now-unnecessary re-export comment in `packages/core-data/src/hooks/memoize.js`.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
manzoorwanijk
added
the
[Type] Code Quality
|
Size Change: -9 B (0%) Total Size: 7.74 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in 47eab5f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24083766696
|
jsnajdr
approved these changes
Apr 7, 2026
adamsilverstein
pushed a commit
that referenced
this pull request
Apr 7, 2026
Co-authored-by: manzoorwanijk <manzoorwanijk@git.wordpress.org> Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow up to #77010 (comment)
Removes the remaining
esModuleInteropcompiler option from the codebase.Why?
As pointed out in the linked review comment,
esModuleInteropwas still enabled inbin/tsconfig.jsonandpackages/wp-build/tsconfig.json. This option is unnecessary and its removal was missed in #77010.How?
esModuleInterop: truefrombin/tsconfig.jsonesModuleInterop: truefrompackages/wp-build/tsconfig.jsonpackages/core-data/src/hooks/memoize.jsTesting Instructions
npx tsc --project bin/tsconfig.json --noEmitandnpx tsc --project packages/wp-build/tsconfig.json --noEmitnpm run buildand verify no errors.Use of AI Tools
Claude Code was used to create the commit and PR.