BlockStyleVariationOverridesWithConfig: change name and fix lint errors#77130
Merged
BlockStyleVariationOverridesWithConfig: change name and fix lint errors#77130
Conversation
jsnajdr
added
[Type] Code Quality
Member
Yes, we could drop the prefix. Probably a leftover before the component became private. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +16 B (0%) Total Size: 7.74 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in 2281c5b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24130966740
|
jsnajdr
requested review from
ajitbohra,
fabiankaegy and
juanmaguitar
as code owners
Member
Author
Thanks for confirming, I pushed another commit that removes the prefix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spinoff from ESLint upgrade in #76654 that fixes one of the linting issues detected there. The problems are:
__unstableprefix, ESLint doesn't detect it as a React component and complains about any hook usage inside. This PR removes the__unstableprefix from the name and adds it back only when actually exporting the name as part ofblock-editorprivate APIs. I wouldn't mind removing the prefix completely, as the function is a private API, it doesn't need an extra prefix. It's used by theeditorpackage.getBlockStylesdependency in auseMemohook. If you look at the Styles: Move global styles data logic to a dedicated package #72464 diff, it removed the actual call ofgetBlockStyles(as agetBlockSelectorsparameter) but forgot the remove the dependency, too. Removing this fixes a warning.