Components: update React function names for better ESLint detection#77148
Merged
Components: update React function names for better ESLint detection#77148
Conversation
jsnajdr
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -164 B (0%) Total Size: 7.74 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in 5c5e1a4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24178774005
|
Contributor
|
Trying to remember why I prefixed that component with |
Member
|
I guess this is ready to be shipped? |
Member
|
Yeah, it should be good to merge. Not sure if similar minor internal changes warrant a changelog entry. |
jsnajdr
force-pushed
the
update/components-names
branch
from
97a78de to
5c5e1a4
Compare
Member
Author
|
Thanks @ciampo for confirmation, I now added also a changelog entry and triggered auto-merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spinoff from ESLint upgrade in #76654. Updates React component names so that ESLint recognizes them as React components and allows hooks usage inside. The
_prefix prevented that detection.I'm removing prefixes from
CustomSelectthat seem unnecessary. @ciampo can you confirm that this is OK? The only identifier that keeps the prefix is_CustomSelectPropsbecause there is alsoCustomSelectProps. The difference is some magic with the type of thesizecomponent, I don't understand this.There's also a
Sandboxname update, using theUnforwardedSandboxconvention to prevent a "no shadow" lint error.After this, #76654 can remove a few disable comments.