LinkPicker: Decode HTML entities in link preview title#77170
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Size Change: +5 B (0%) Total Size: 7.74 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in e2e3e57. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24170916879
|
t-hamano
changed the title
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
reviewed
Apr 9, 2026
| className="link-preview-button__title" | ||
| > | ||
| { title } | ||
| { stripHTML( title ) } |
Member
There was a problem hiding this comment.
The stripHTML removes HTML, but I don't think it decodes the entities.
Contributor
Author
There was a problem hiding this comment.
I think __unstableStripHTML (stripHTML) does decode the entities:
wp.dom.__unstableStripHTML( '<b>Hello & World</b>' )
// => "Hello & World"
Member
There was a problem hiding this comment.
I wanted to ask whether we need to do something like decodeEntities( stripHTML( title ) )
Member
There was a problem hiding this comment.
Oh, I should have just searched 😄
If we trust fetchLinkSuggestions then maybe no?
Member
There was a problem hiding this comment.
TIL. We usually use decodeEntities in the codebase. If it works then why change :D
Contributor
Author
There was a problem hiding this comment.
My prediction is that if unpredictable HTML might be included, stripHTML might be better than decodeEntities. For example, stripHTML is also used in the post title:
If we trust
fetchLinkSuggestionsthen maybe no?
Perhaps fetchLinkSuggestions is intended for search results 🤔
Member
There was a problem hiding this comment.
Perhaps fetchLinkSuggestions is intended for search results
Well... there is that too! 😆 Sorry I was in a rabbit hole.
I think with decodeEntities is fine if we're unsure if we're getting entity-encoded values. I just tested and couldn't break it. Not that that means much!
ramonjd
approved these changes
Apr 9, 2026
Member
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
LGTM
| Before | After |
|---|---|
 |
 |
I tested locally and in Playground. My Playground instance didn't like the <> in the link previewer 🤔
Locally it's okay
Contributor
Author
This is likely related to loopback requests not working in wp-env. A similar issue has been reported in #77057 (comment). This should be resolved by #77155. |
t-hamano
added
props-bot
github-actions
bot
removed
the
Backport to WP 7.0 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Apr 9, 2026
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/7.0 branch to get it included in the next release: 7f77de5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this issue while reviewing #77155
What?
Fix HTML entities not being decoded in the
LinkPickercomponent.Why?
This happened because the title was rendered directly as
{ title }in JSX without any processing. React renders JSX text content as plain text nodes, so HTML entities are not decoded automatically.How?
Apply
stripHTML()to thetitleprop before rendering it. This approach is consistent with the behavior in link-control/link-preview.js.Testing Instructions
Sample & Page <>🙂)Sample & Page <>🙂Sample & Page <>🙂Screenshots or screencast
Before
After
Use of AI Tools
Claude Sonnet 4.6 (Claude Code) was used to assist with identifying the root cause and implementing the fix. The change was reviewed and committed by the author.