Connectors: Replace speak() with notice store for state changes#77174
Merged
Connectors: Replace speak() with notice store for state changes#77174
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 7.74 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 3eb00f1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24274918115
|
Member
|
I tested using the snippet included in the testing instructions with VoiceOver on Safari, and it works as expected: 
Aside: |
gziolo
approved these changes
Apr 10, 2026
Replace @wordpress/a11y speak() calls with createSuccessNotice and createErrorNotice from @wordpress/notices for plugin install/activate and connector connect/disconnect state changes. This surfaces feedback visually in addition to announcing it to screen readers, and aligns with the snackbar notice pattern used elsewhere in the codebase for async operation results. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Thanks for the feedback! I have replaced all instances of "speak" with snackbars. What do you think? 60293a423104bd3cb618b1b71ccc4b52.mp4 |
t-hamano
changed the title
github-actions
bot
removed
the
Backport to WP 7.0 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Apr 11, 2026
* Connectors: Show error notice when plugin install or activation fails Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Connectors: Replace speak() with notice store for state changes Replace @wordpress/a11y speak() calls with createSuccessNotice and createErrorNotice from @wordpress/notices for plugin install/activate and connector connect/disconnect state changes. This surfaces feedback visually in addition to announcing it to screen readers, and aligns with the snackbar notice pattern used elsewhere in the codebase for async operation results. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/7.0 branch to get it included in the next release: 209cde7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #77089
What?
When plugin installation or activation fails on the Connectors page, display a visible error message along with screen reader text.
Why?
Otherwise, users not using a screen reader will not understand what is happening when an error occurs.
How?
Display an error snackbar notice instead of using
speak()directly. Ideally, server-side error text should probably be included in the message, but since the translation strings are already frozen for the 7.0 release, I preserve the previous error message.Testing Instructions
Screenshots or screencast
c8de5f499ab499e4c97b958dac20ad7b.mp4
Use of AI Tools
This PR was authored with assistance from Claude Code (Anthropic).