Dataviews: remove unneeded ref callbacks#77179
Merged
Conversation
manzoorwanijk
approved these changes
Apr 9, 2026
Member
manzoorwanijk
left a comment
manzoorwanijk
left a comment
There was a problem hiding this comment.
It's weird that we had to do that in the first place. Thank you for the cleanup.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -146 B (0%) Total Size: 7.74 MB 📦 View Changed
ℹ️ View Unchanged
|
jsnajdr
force-pushed
the
fix/dataviews-ref-types
branch
from
b9bc1e2 to
d1677a2
Compare
|
Flaky tests detected in d1677a2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24187458999
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spinoff from ESLint upgrade in #76654 where there is a new error detected (from the
react-compilerplugin, false positive) when assigning refs in thesetElementReffunction.It turns out that these functions can be removed completely and we can pass the
refobject directly to theComposite.Itemcomponent. All we need is to fixup the type of theuseRefcall. That was probably the original reason for adding the callback -- a type error.