RTC: Fix button flickering on retry dialog#77234
Merged
alecgeatches merged 1 commit intotrunkfrom Apr 10, 2026
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -224 B (0%) Total Size: 7.74 MB 📦 View Changed
ℹ️ View Unchanged
|
alecgeatches
added
[Type] Bug
|
Flaky tests detected in d8d6f11. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24253852412
|
maxschmeling
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Small fix for an issue that causes the disconnect dialog buttons to briefly flicker when "Retry" is clicked:
After the fix, the layout is stabilized:
Why?
Avoid an annoying layout flicker when retrying.
How?
The retry button rendering is gated on
manualRetry, which checks for the connection'scanManuallyRetryvalue. During theconnectingstatuscanManuallyRetryis briefly not present, which caused the button to disappear.The changes in this PR add
isManualRetryAvailable, which essentially works the same but ignores theconnectingstate so the button stays in place.Testing Instructions
Use of AI Tools
Used: Claude
For: Implementation