DataViews: Use --wpds-cursor-control design token for interactive controls#77259
Conversation
|
Thanks for the PR, please also update the |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
The components folks will have more context than I do about whether this is ready for usage. |
ciampo
left a comment
There was a problem hiding this comment.
The PR description looks out of date:
"verify they reflect the design token value (defaults to
defaultcursor)"
The --wpds-cursor-control token was changed from default to pointer in #76762. The current default is pointer, so the behavior after this PR should be visually identical to the old hardcoded cursor: pointer.
We should update the testing instructions.
ciampo
left a comment
There was a problem hiding this comment.
LGTM 🚀
Thank you for working on this 🙏
What?
Part of #76221
Replaces hardcoded
cursor: pointerdeclarations in@wordpress/dataviewsstylesheets withcursor: var(--wpds-cursor-control), and adds a stylelint rule to prevent newcursor: pointerdeclarations from being introduced.Why?
The
--wpds-cursor-controltoken allows cursor behavior for interactive non-link controls to be configured centrally via the design system.@wordpress/dataviewshad hardcodedpointercursors across its layouts and filter components, which prevented them from following the shared design system setting.How?
cursor: pointerwithcursor: var(--wpds-cursor-control)in the relevant Sass styles files.Testing Instructions
npm run storybook:dev.pointercursor).Use of AI Tools
Use Claude Code to review code and create pull request description.