page.waitForFunction: fix call arguments#77300
Merged
Conversation
jsnajdr
added
[Type] Bug
Mamaduka
approved these changes
Apr 14, 2026
Member
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
Good catch. I'm guessing the initial pattern was leftover from Puppeteer, and then it spread.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 7.74 MB ℹ️ View Unchanged
|
|
Flaky tests detected in a60de15. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24390742287
|
Member
If it wasn't being applied and it wasn't a problem, does that suggest we don't need to be customizing the timeout in the first place? |
Member
|
It's best practice to avoid custom timeouts, unless it's really needed due to some other issues - test being flaky, some unresolved race conditions, etc. IMO, it would be hard to say that this wasn't a problem, and there were no more flaky test reports without these options. |
Member
Author
Maybe it just reduces frequency of flaky test failures. Our CI restarts such tests, so in the end such tests end up green anyway. Just with fewer or more retries. I also suspect that this patch reduced permanent failures in the React 19 upgrade in #61521. The PR used to be perfectly green, but then one day, after a rebase or after an underlying WP update, started failing often on RTC e2e tests. I don't really understand what is going on, at this moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes calls to
page.waitForFunctionin e2e tests. When we want to specify a timeout, it must be the third argument. The second argument areargsto be passed to the function.In our case, the
timeoutwasn't really applied, the value was instead sent to the callback as argument.This is a spinoff from the React 19 upgrade in #61521 where it helped fix some e2e failures.