Tabs: remove sequential numbering from new tab labels#77321
Merged
Conversation
New tabs no longer receive auto-incremented "Tab N" labels and placeholders; users set their own titles instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
t-hamano
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -57 B (0%) Total Size: 7.74 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in 88b7c1d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24396580137
|
Contributor
|
My concern here is that we aren't being consistent with what we are calling "Tab". In the list view the "Tab" is the content, whereas here you're using the word "Tab" to refer to the "Tab Menu Item". I don't love the naming of the blocks as they are though, so I don't feel great about standardising around that: What do you think about using "Tab name"? instead of "Tab"? |
scruffian
approved these changes
Apr 14, 2026
Contributor
scruffian
left a comment
scruffian
left a comment
There was a problem hiding this comment.
I think this makes sense. I have a question about the text to use, but that shouldn't stop this from merging.
Member
I think it's OK to leave this as "Tab" for now. I also think we need to rename the Tabs blocks, possibly to match the WCAG Tabs pattern example. In their example pattern, the tab labels (or Tab Menu Items as we currently call them) are "Tabs". Just as a side note, I've opened a separate issue for these block names here: #77341 |
Contributor
Author
|
Thanks for the review! Regarding naming, it would probably be best to discuss it in #77341. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#77189 (comment)
What?
Removes the logic that auto-assigns sequential numbers (e.g.
Tab 1,Tab 2) when new tabs are added to the Tabs block, including the numbered placeholder on the tabs-menu-item.Why?
Unfortunately, the current tab number increment does not work in several scenarios. For example,
Tab 1andTab 2Tab 1,Tab 2, andTab 3Tab 1andTab 3Tab 1,Tab 3, andTab 3To solve this problem, I will avoid adding the number itself to the tab. The tab text can be freely modified by the user, and it is unlikely that many users will use the automatically generated tab text.
Testing Instructions
Tab.TabScreenshots or screencast
Use of AI Tools
This PR was drafted with the assistance of Claude Code (Anthropic). All changes were reviewed and verified by the author before submission.