Block Editor: Extract getElementCSSRules from useBlockProps#77327
Merged
Block Editor: Extract getElementCSSRules from useBlockProps#77327
Conversation
Extract the element CSS rules generation logic from the useMemo callback in useBlockProps into a standalone pure function. This improves readability and makes the logic independently testable. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
scruffian
added
the
[Type] Code Quality
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Size Change: +9 B (0%) Total Size: 7.74 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in 9eed85d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24398083795
|
MaggieCabrera
approved these changes
Apr 14, 2026
Contributor
MaggieCabrera
left a comment
MaggieCabrera
left a comment
There was a problem hiding this comment.
Makes the CSS rules logic independently testable
Should we add some tests? can we even, given that the function is not exported?
Either way I'm fine with this, it makes sense to me. Thanks for helping out here!
Contributor
Author
|
Happy for us to add tests - that can be a followup :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Extracts the element CSS rules generation logic from the
useMemocallback inuseBlockPropsinto a standalonegetElementCSSRulesfunction inpackages/block-editor/src/hooks/style.js.Why?
The inline logic for building element CSS rules (buttons, links, headings, pseudo-selectors, sub-elements) was nested inside
useBlockProps'suseMemo. Extracting it into a named pure function:useBlockPropsHow?
getElementCSSRules( blockElementStyles, blockName, baseSelector )as a private helperuseBlockPropsnow callsgetElementCSSRulesinside itsuseMemowith the same dependency arrayTesting Instructions
🤖 Generated with Claude Code