WIP: Try revisions with picker-activity layout#77333
Draft
ntsekouras wants to merge 1 commit intotrunkfrom
Draft
WIP: Try revisions with picker-activity layout#77333ntsekouras wants to merge 1 commit intotrunkfrom
ntsekouras wants to merge 1 commit intotrunkfrom
Conversation
ntsekouras
requested review from
Mamaduka,
ellatrix,
jameskoster,
jasmussen,
oandregal and
t-hamano
ntsekouras
added
[Type] Enhancement
github-actions
Bot
added
[Package] Editor
|
Size Change: +5 kB (+0.06%) Total Size: 7.75 MB 📦 View Changed
ℹ️ View Unchanged
|
Member
Why do we need a |
Contributor
Author
What we want is more of a navigational UI where we How do you think the existing DataViews activity layout would be better? I could be wrong with my initial approach. |
Contributor
|
If we end up using Could the DataViews instance fill the vertical space in the Inspector regardless of visible entries/length? Ideally the pagination controls are sticky at the bottom of the panel. This change summary probably isn't very useful, maybe we start without it: 
My only other question is whether we need the "Open classic revisions screen" link? |
Member
|
Thanks, Nik! Nice work with the timeline/activity panel. I know it's not a new problem, but displaying serialized changes (Foonotes example), doesn't seem to provide any benefits. Maybe in this PR we should just focus on display general data (date, author, etc). We can improve summaries in follow-up. There's also a proposal to allow naming revisions: #60394.
I think we need it, at least unit everything is polished. See #77349. |
t-hamano
reviewed
Apr 16, 2026
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR. I might be missing something, but adding a new picker component seems like the best option. Can we add Storybook first so we can refine the design? Alternatively, we could split this PR and focus on adding the ViewPickerActivity component first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of: #77188
This PR explores adding a revisions timeline in inspector controls, when in-editor revisions mode is enabled.
We should have in mind how to bring greater parity to the revision experience in Global Styles and Posts/Pages/Templates.
This PR is a very rough POC to start design discussions and the focus should not be at the code, as while I steered AI a bit, I haven't reviewed or perfected most of it.
Also this PR will not 'touch' the revisions panels at all. This should be explored separately.
How
I think what we're trying to do here based on the discussions is have a navigational UI for the revisions (similar to the GS one) so DataViewsPicker seem like the best fit for it.
I created a new
pickerActivitylayout and tried to match just a bit the styles with GS.Notes
post metathere is a panel that shows the diff, which I copied the existing functionality that is now rendered as a panel (meta).activityandpickerActivitylayouts diverge? Do we want to keep the same styling withdescriptionfield and the other fields? This will also affect how we will show the extra info for each item.49 words, 1 minute read time.restorebutton, but it should be similar to theView itemactions in activity layout.revisionslink in inspector controls? There is a suggestion to make theLast edited 2 days agoa link, if there are revisions. Would that be clear and easily discoverable? Any other suggestions or should I try that one out?Testing Instructions
revisionsin inspector controls5items per page to see the pagination more easily.Video
Screen.Recording.2026-04-14.at.4.53.26.PM.mov
Use of AI Tools
Opus 4.6