Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
aduth
approved these changes
Apr 15, 2026
Member
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
I noticed this as well before and wondered if there might be some advantage is being intentionally narrow in what we want to support (e.g. explicitly not supporting *.scss imports). Probably not worth the deviation.
It did also prompt to wonder if the other types/ we have are still needed under types (specifically react.d.ts). Did you check that one?
|
Size Change: 0 B Total Size: 7.75 MB ℹ️ View Unchanged
|
|
Flaky tests detected in ddf45b1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24468372403
|
Member
Author
Good point. I think we can lift that up into a root typing so other packages can use it too. I'll follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to the shared TypeScript style import typings setup by switching
@wordpress/uito the existingstyle-importsdefinitions.Why?
@wordpress/uihad a package-local*.module.cssdeclaration that duplicated part of the shared typing already available intypings/style-imports.How?
style-importstopackages/ui/tsconfig.jsonpackages/ui/src/types/css-modules.d.tsdeclaration fileTesting Instructions
./node_modules/.bin/tsc -p packages/ui/tsconfig.json --pretty false.Use of AI Tools
Cursor was used to help prepare the change and draft this pull request. I reviewed the result before submitting it.