Merged
Conversation
mirka
added
the
[Type] Automated Testing
mirka
changed the title
|
Size Change: 0 B Total Size: 7.75 MB ℹ️ View Unchanged
|
|
Flaky tests detected in c88fb89. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24755989036
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
aduth
approved these changes
Apr 20, 2026
Comment on lines
-352
to
+357
| await waitFor( () => | ||
| expect( screen.getByRole( 'menu' ) ).toHaveFocus() | ||
| ); | ||
| await waitForFocusedMenu(); |
Member
There was a problem hiding this comment.
I wondered if we actually needed to be awaiting these, or if we can expect it to be synchronous once the menu is open. Your PR description mentions "Leaves the synchronous assertions in place for stable in-menu navigation where focus is already inside the same menu context". Is it not referring to this?
Member
Author
There was a problem hiding this comment.
I tried trimming that one further by making the defaultOpen focus assertion synchronous, but it immediately failed locally on the same expectation, so I restored the waitFor.
Comment on lines
+891
to
+894
| await waitFor( () => { | ||
| expect( outerButton ).toHaveFocus(); | ||
| expect( screen.queryByRole( 'menu' ) ).not.toBeInTheDocument(); | ||
| } ); |
Member
There was a problem hiding this comment.
Minor:
- Do we need to be awaiting both of these things (i.e. is each independently flakey) or can we await only the focus change and then break out the remaining assertion.
- Related point: I wonder if we can reuse the utility for detecting the outer button, so we'd have something like:
Suggested change
| await waitFor( () => { | |
| expect( outerButton ).toHaveFocus(); | |
| expect( screen.queryByRole( 'menu' ) ).not.toBeInTheDocument(); | |
| } ); | |
| await waitForFocusedButton( 'Button outside of dropdown' ); | |
| expect( screen.queryByRole( 'menu' ) ).not.toBeInTheDocument(); |
Member
Author
There was a problem hiding this comment.
Trimmed the changeset down further so it generally only addresses the historically-known failures (listed in the PR description). Passed on 10 test runs, so good enough as a first try. We can expand if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This updates
packages/components/src/menu/test/index.tsxto stabilize focus assertions across theMenutest file, by adding shared async focus helpers and uses them for the focus transitions that were failing intermittently in CI.Why?
The common pattern in recent unit test failures on CI is that focus sometimes lands on an intermediate element first, then settles on the expected target a moment later.
That showed up in recent logs as:
Submenu item 1, but focus was still on the submenurole="menu"container.Taken together, those runs suggest a broader focus-settling race in this test file rather than a single isolated flaky assertion.
How?
Testing Instructions
npm run test:unit -- packages/components/src/menu/test/index.tsx --runInBand.packages/components/src/menu/test/index.tsxpasses.npm run test:unit -- packages/components/src/menu/test/index.tsx --runInBand.