Improve wording clarity in Image block placeholder text#77441
Improve wording clarity in Image block placeholder text#77441Ashok-A15 wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @Ashok-A15. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Ashok-A15! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
Thanks for the PR, @Ashok-A15! I don't see an associated issue. Was it discussed anywhere? I'm not a native English speaker, but I don't think "it" changes anything. IMO, these instructions list available actions and in that context, the "upload" string makes sense. Additionally, similar string are also present in @ramonjd, can I get a second opinion on my English? :) |
|
I only speak Australian! I don't see much value in adding "it" here. If we were talking about a specific image, like Like - you have But here it's general instructional/hint text and I think not worth the extra translation effort required. If other locales need the object here, they would have added it already. English (and Australian!) doesn't in my opinion. |
This PR updates the wording of the Image block placeholder text for improved readability.
Changed:
"upload" → "upload it"