Skip to content

Improve wording clarity in Image block placeholder text#77441

Closed
Ashok-A15 wants to merge 1 commit intoWordPress:trunkfrom
Ashok-A15:trunk
Closed

Improve wording clarity in Image block placeholder text#77441
Ashok-A15 wants to merge 1 commit intoWordPress:trunkfrom
Ashok-A15:trunk

Conversation

@Ashok-A15
Copy link
Copy Markdown

@Ashok-A15 Ashok-A15 commented Apr 17, 2026

This PR updates the wording of the Image block placeholder text for improved readability.

Changed:
"upload" → "upload it"

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 17, 2026

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Required label: Any label starting with [Type].
  • Labels found: [Package] Block library, [Block] Image, First-time Contributor.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 17, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @Ashok-A15.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: Ashok-A15.

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions Bot added [Package] Block library /packages/block-library First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository labels Apr 17, 2026
@github-actions
Copy link
Copy Markdown

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Ashok-A15! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@Mamaduka
Copy link
Copy Markdown
Member

Mamaduka commented Apr 17, 2026

Thanks for the PR, @Ashok-A15! I don't see an associated issue. Was it discussed anywhere?

I'm not a native English speaker, but I don't think "it" changes anything. IMO, these instructions list available actions and in that context, the "upload" string makes sense.

Additionally, similar string are also present in packages/block-editor/src/components/media-placeholder/index.js.

@ramonjd, can I get a second opinion on my English? :)

@ramonjd
Copy link
Copy Markdown
Member

ramonjd commented Apr 17, 2026

I only speak Australian! :trollface:

I don't see much value in adding "it" here. If we were talking about a specific image, like cat.gif then it would make more sense as an object in the sentence.

Like - you have cat.gif, you can drag and drop it, or upload it.

But here it's general instructional/hint text and I think not worth the extra translation effort required. If other locales need the object here, they would have added it already. English (and Australian!) doesn't in my opinion.

@t-hamano t-hamano added the [Block] Image Affects the Image Block label Apr 17, 2026
@Mamaduka Mamaduka closed this Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Image Affects the Image Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Block library /packages/block-library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants