Fix cursor position during forward delete of empty blocks#77525
Open
dpmehta wants to merge 1 commit intoWordPress:trunkfrom
Open
Fix cursor position during forward delete of empty blocks#77525dpmehta wants to merge 1 commit intoWordPress:trunkfrom
dpmehta wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #64235
Fixes an issue where the cursor incorrectly moves to the end of the preceding block when forward-deleting an empty paragraph, instead of moving into the following block.
Note : It is already tested that this issue only happening with paragraph block as it is default block, i have tested with heading block as well in that issue does not happen for it cursor correctly moves to beginning of third heading.
Why?
When performing a "Forward Delete" at the end of a block, a forward merge is triggered. If the current block is an "unmodified default block" (like an empty Paragraph), the
mergeBlocksaction removes it.Previously, this removal defaulted to moving the selection to the previous block. For a Backspace (reverse merge), this makes sense, but for a Forward Delete, where the user wants to go to the next block, it doesn't.
How?
In
packages/block-editor/src/store/actions.js, themergeBlockslogic has been updated for unmodified default blocks. When a forward merge is triggered and the block being removed is the currently selected one, the action now explicitly selects the next block (clientIdB) at the start position (offset 0), ensuring the cursor moves forward rather than backward.Testing Instructions
Screenshots or screencast
Before Fix :
After Fix
Use of AI Tools
AI ( Gemini 3.1 Pro ) was used to trace the
mergeBlocksaction logic and draft this PR description.